Re: [RFC PATCH 09/20] famfs: Add super_operations
From: John Groves
Date: Tue Feb 27 2024 - 12:48:45 EST
On 24/02/26 12:51PM, Jonathan Cameron wrote:
> On Fri, 23 Feb 2024 11:41:53 -0600
> John Groves <John@xxxxxxxxxx> wrote:
> > + */
> > +static int famfs_show_options(
> > + struct seq_file *m,
> > + struct dentry *root)
> Not that familiar with fs code, but this unusual kernel style. I'd go with
> something more common
>
> static int famfs_show_options(struct seq_file *m, struct dentry *root)
Actually, xfs does function declarations and prototypes this way, not sure if
it's everywhere. But I like this format because changing one argument usually
doesn't put un-changed args into the diff.
So I may keep this style after all.
John