Re: [PATCH] mm: export folio_pte_batch as a couple of modules might need it

[Barry Song]

On Wed, Feb 28, 2024 at 5:00 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Tue, Feb 27, 2024 at 03:40:50PM +1300, Barry Song wrote:
> > From: Barry Song <v-songbaohua@xxxxxxxx>
> >
> > madvise and some others might need folio_pte_batch to check if a range
> > of PTEs are completely mapped to a large folio with contiguous physcial
> > addresses. Let's export it for others to use.
>
> It doesn't look exported to me in the patch (and that's a good thing!).
>
> But even for making it non-static you probably want to include that in
> the series actually making use of it.

at least two parallel jobs[1][2] (maybe more ) need it right now.
Getting this one pulled in early
will help build a common base for them and avoid duplicates&conflicts in them.

[1] https://lore.kernel.org/linux-mm/20240118111036.72641-7-21cnbao@xxxxxxxxx/
[2] https://lore.kernel.org/linux-mm/20240225123215.86503-1-ioworker0@gmailcom/
>
> > +extern int folio_pte_batch(struct folio *folio, unsigned long addr,
> > +             pte_t *start_ptep, pte_t pte, int max_nr, fpb_t flags,
> > +             bool *any_writable);
>
> no need for the extern here.

Yes. this has been moved to internal.h as "static inline" in v2:
https://lore.kernel.org/linux-mm/20240227104201.337988-1-21cnbao@xxxxxxxxx/

Thanks
Barry