Re: [PATCH v3 1/5] dt-bindings: arm: msm: Add llcc Broadcast_AND register

From: Unnathi Chalicheemala
Date: Tue Feb 27 2024 - 20:04:56 EST


On 2/27/2024 7:47 AM, Krzysztof Kozlowski wrote:
> On 23/02/2024 00:07, Unnathi Chalicheemala wrote:
>> The LLCC block in SM8450, SM8550 and SM8650 have a new register
>> space for Broadcast_AND region. This is used to check that all
>> channels have bit set to "1", mainly in SCID activation/deactivation.
>>
>> Previously we were mapping only the Broadcast_OR region assuming
>> there was only one broadcast register region. Now we also map
>> Broadcast_AND region.
>>
>> Signed-off-by: Unnathi Chalicheemala <quic_uchalich@xxxxxxxxxxx>
>
> Why did you ignore the tags? Qualcomm upstreaming guide covers this
> case, so please read it before sending patches.
>

I was asked to remove the Reviewed-by tag as the previous version of the
patch gave errors on running 'make DT_CHECKER_FLAGS=-m dt_binding_check',
that's why I dropped it.
It was sometime ago, https://lore.kernel.org/all/d78b4bce-7bcd-4ab0-a76b-135cee3ec9b0@xxxxxxxxxx/

> Best regards,
> Krzysztof
>