Re: [PATCH] net: usb: dm9601: fix wrong return value in dm9601_mdio_read

From: patchwork-bot+netdevbpf
Date: Tue Feb 27 2024 - 22:20:53 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Sun, 25 Feb 2024 00:20:06 +0100 you wrote:
> The MII code does not check the return value of mdio_read (among
> others), and therefore no error code should be sent. A previous fix to
> the use of an uninitialized variable propagates negative error codes,
> that might lead to wrong operations by the MII library.
>
> An example of such issues is the use of mii_nway_restart by the dm9601
> driver. The mii_nway_restart function does not check the value returned
> by mdio_read, which in this case might be a negative number which could
> contain the exact bit the function checks (BMCR_ANENABLE = 0x1000).
>
> [...]

Here is the summary with links:
- net: usb: dm9601: fix wrong return value in dm9601_mdio_read
https://git.kernel.org/netdev/net/c/c68b2c9eba38

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html