Re: [PATCH v3] ASoC: dt-bindings: img,spdif-in: Convert to dtschema

From: Krzysztof Kozlowski
Date: Wed Feb 28 2024 - 02:38:59 EST


On 27/02/2024 18:03, Javier García wrote:
> Convert the Imagination Technologies SPDIF Input Controllerto DT schema.
>
> Signed-off-by: Javier García <javier.garcia.ta@xxxxxxxx>

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.

> ---
> Changes since v1 and v2:
> - re-written the subject inline to include relevant prefix
>
> - Node name changed to spdif@18100e00 to be more generic

..

> diff --git a/Documentation/devicetree/bindings/sound/img,spdif-in.yaml b/Documentation/devicetree/bindings/sound/img,spdif-in.yaml
> new file mode 100644
> index 000000000000..ab8f96cc37cd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/img,spdif-in.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagination Technologies SPDIF Input Controller
> +
> +maintainers:
> + - Liam Girdwood <lgirdwood@xxxxxxxxx>
> + - Mark Brown <broonie@xxxxxxxxxx>

That's still not good choice... that's the problem with converting
bindings for very old, unmaintained hardware. No one cares. If you care
about MIPS and Pistachio platform, then put your name there. If you do
not care and we cannot find anyone responsible, then your effort has
little impact. Better focus on bindings for actively used hardware.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof