Re: [PATCH] net: fman: Use common error handling code in dtsec_init()

From: Jiri Pirko
Date: Wed Feb 28 2024 - 02:52:08 EST


Wed, Feb 28, 2024 at 03:46:57AM CET, kuba@xxxxxxxxxx wrote:
>On Tue, 27 Feb 2024 14:14:52 +0100 Markus Elfring wrote:
>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function implementation.
>
>Okay, but..
>
>> .../net/ethernet/freescale/fman/fman_dtsec.c | 19 +++++++++++--------
>> 1 file changed, 11 insertions(+), 8 deletions(-)
>
>..you've added more lines than you've removed so what's the point.

To have cleaner error path? Not always lines of code is the correct
indicator of patch quality :)


>--
>pw-bot: reject
>