Re: net: fman: Use common error handling code in dtsec_init()

From: Markus Elfring
Date: Wed Feb 28 2024 - 03:44:22 EST


>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function implementation.
>
> Okay, but..
>
>> .../net/ethernet/freescale/fman/fman_dtsec.c | 19 +++++++++++--------
>> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> ..you've added more lines than you've removed so what's the point.

* Can the change acceptance grow any more for attempts to improve error handling
another bit?

* Would you like to fiddle with scope-based resource management?
https://elixir.bootlin.com/linux/v6.8-rc6/source/include/linux/cleanup.h#L8

See also:
Article by Jonathan Corbet from 2023-06-15
https://lwn.net/Articles/934679/


> --
> pw-bot: reject

Can such an reaction be reconsidered once more?

Regards,
Markus