Re: [PATCH] platform/x86: thinkpad_acpi: Add more ThinkPads with non-standard reg address for fan

[Hans de Goede]

Hi,

On 2/28/24 16:01, Vishnu Sankar wrote:
> Add more ThinkPads with non-standard register addresses to read fan values.
> 
> ThinkPads added are L13 Yoga Gen1, X13 Yoga Gen1, L380, L390, 11e Gen5 GL,
> 11e Gen5 GL-R, 11e Gen5 KL-Y.
> 
> Signed-off-by: Vishnu Sankar <vishnuocv@xxxxxxxxx>

Thanks, I have no objection against this patch:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

But this feels like it will become a game of whack-a-mole.

Mark can you reach out to the ThinkPad firmware team and
figure out if there is some supported way to automatically detect
this ?

Regards,

Hans



> ---
>  drivers/platform/x86/thinkpad_acpi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 5ecd9d33250d..23b2abe44a5a 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8767,6 +8767,13 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
>  	TPACPI_Q_LNV3('N', '3', '7', TPACPI_FAN_2CTL),  /* T15g (2nd gen) */
>  	TPACPI_Q_LNV3('R', '1', 'F', TPACPI_FAN_NS),	/* L13 Yoga Gen 2 */
>  	TPACPI_Q_LNV3('N', '2', 'U', TPACPI_FAN_NS),	/* X13 Yoga Gen 2*/
> +	TPACPI_Q_LNV3('R', '0', 'R', TPACPI_FAN_NS),	/* L380 */
> +	TPACPI_Q_LNV3('R', '1', '5', TPACPI_FAN_NS),	/* L13 Yoga Gen 1 */
> +	TPACPI_Q_LNV3('R', '1', '0', TPACPI_FAN_NS),	/* L390 */
> +	TPACPI_Q_LNV3('N', '2', 'L', TPACPI_FAN_NS),	/* X13 Yoga Gen 1 */
> +	TPACPI_Q_LNV3('R', '0', 'T', TPACPI_FAN_NS),	/* 11e Gen5 GL */
> +	TPACPI_Q_LNV3('R', '1', 'D', TPACPI_FAN_NS),	/* 11e Gen5 GL-R */
> +	TPACPI_Q_LNV3('R', '0', 'V', TPACPI_FAN_NS),	/* 11e Gen5 KL-Y */
>  	TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN),	/* X1 Tablet (2nd gen) */
>  };
>