Re: [RFC] net: hsr: Provide RedBox support

[Andrew Lunn]

On Wed, Feb 28, 2024 at 08:31:15AM -0800, Stephen Hemminger wrote:
> On Wed, 28 Feb 2024 16:07:35 +0100
> Lukasz Majewski <lukma@xxxxxxx> wrote:
> 
> >  
> > +/* hsr_proxy_node_table_show - Formats and prints proxy node_table entries */
> > +static int
> > +hsr_proxy_node_table_show(struct seq_file *sfp, void *data)
> > +{
> > +	struct hsr_priv *priv = (struct hsr_priv *)sfp->private;
> > +	struct hsr_node *node;
> > +
> > +	seq_printf(sfp, "Proxy Node Table entries for HSR device\n");
> > +	seq_puts(sfp, "MAC-Address-SAN,        time_in\n");
> > +	rcu_read_lock();
> > +	list_for_each_entry_rcu(node, &priv->proxy_node_db, mac_list) {
> > +		seq_printf(sfp, "%pM ", &node->macaddress_A[0]);
> > +		seq_printf(sfp, "%10lx\n", node->time_in[HSR_PT_INTERLINK]);
> > +	}
> > +	rcu_read_unlock();
> > +	return 0;
> > +}
> > +
> >  DEFINE_SHOW_ATTRIBUTE(hsr_node_table);
> > +DEFINE_SHOW_ATTRIBUTE(hsr_proxy_node_table);
> 
> NAK
> Do not abuse sysfs to be a debug proc style output.

This is actually debugfs, not sysfs.

However, i agree, we want information like this exported via netlink
as the primary interface to the end user. debugfs is not suitable for
that.

	 Andrew