Re: [PATCH v5 2/8] usb: misc: onboard_hub: rename to onboard_dev

[Javier Carrasco]

On 28.02.24 19:18, Matthias Kaehlcke wrote:
> On Wed, Feb 28, 2024 at 02:51:29PM +0100, Javier Carrasco wrote:
>> This patch prepares onboad_hub to support non-hub devices by renaming
>> the driver files and their content, the headers and their references.
>>
>> The comments and descriptions have been slightly modified to keep
>> coherence and account for the specific cases that only affect onboard
>> hubs (e.g. peer-hub).
>>
>> The "hub" variables in functions where "dev" (and similar names) variables
>> already exist have been renamed to onboard_dev for clarity, which adds a
>> few lines in cases where more than 80 characters are used.
>>
>> No new functionality has been added.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco@xxxxxxxxxxxxxx>
>> ---
>>  ...-usb-hub => sysfs-bus-platform-onboard-usb-dev} |   3 +-
>>  MAINTAINERS                                        |   4 +-
>>  drivers/usb/core/Makefile                          |   4 +-
>>  drivers/usb/core/hub.c                             |   8 +-
>>  drivers/usb/core/hub.h                             |   2 +-
>>  drivers/usb/misc/Kconfig                           |  16 +-
>>  drivers/usb/misc/Makefile                          |   2 +-
>>  drivers/usb/misc/onboard_usb_dev.c                 | 519 +++++++++++++++++++++
>>  .../misc/{onboard_usb_hub.h => onboard_usb_dev.h}  |  28 +-
>>  ...ard_usb_hub_pdevs.c => onboard_usb_dev_pdevs.c} |  47 +-
>>  include/linux/usb/onboard_dev.h                    |  18 +
>>  include/linux/usb/onboard_hub.h                    |  18 -
>>  12 files changed, 595 insertions(+), 74 deletions(-)
> 
> This does not rename/delete onboard_usb_hub.c. With a rename there would
> probably be an actual diff for onboard_usb_dev.c instead of a new file,
> which would help with reviewing.

Thanks, I noticed that when I started working on v6 and it has been
fixed. I must have lost that one when fixing conflicts during the patch
re-ordering.

Best regards,
Javier Carrasco