Re: [PATCH] docs: submit-checklist: structure by category
From: Randy Dunlap
Date: Wed Feb 28 2024 - 18:04:38 EST
Hi Lukas,
Sorry about the (my) delay.
On 2/26/24 02:46, Lukas Bulwahn wrote:
>
> Documentation/process/submit-checklist.rst | 157 +++++++++++----------
> 1 file changed, 84 insertions(+), 73 deletions(-)
>
> diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
> index b1bc2d37bd0a..7d8dba942fe8 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -11,110 +11,121 @@ These are all above and beyond the documentation that is provided in
> and elsewhere regarding submitting Linux kernel patches.
>
>
> +*Review your code:*
These "headings" (?) shouldn't have ending ':'s IMO.
Maybe they should be real headings?
Otherwise the patch is a very good & welcome improvement, although as
Jon said, the file needs some TLC. (after this patch is applied)
Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Tested-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.
--
#Randy