Re: [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config

From: Frank Li
Date: Wed Feb 28 2024 - 18:37:18 EST


On Wed, Feb 28, 2024 at 05:05:20PM -0600, Bjorn Helgaas wrote:
> On Tue, Feb 27, 2024 at 04:47:09PM -0500, Frank Li wrote:
> > pci-imx6.c and PCI_IMX6 actuall for all i.MX chips (i.MX6x, i.MX7x, i.MX8x,
> > i.MX9x). Remove '6' to avoid confuse.
>
> s/actuall for all/cover all/
> s/confuse/confusion/
>
> > drivers/pci/controller/dwc/{pci-imx6.c => pci-imx.c} | 0
>
> If we're going to rename it, we should rename it to "pcie-imx.c".

Good. I will update it.

>
> It was my mistake long ago to use "pci-" instead of "pcie-".
>
> > -config PCI_IMX6
> > +config PCI_IMX
>
> What does this look like to users who carry an old .config file
> forward?

I don't think people will use old .config when update to new kernel. I can
keep PCI_IMX6 for config if have to.