Re: [PATCH v2 06/11] x86/unwind/orc: Convert global variables to static

From: Josh Poimboeuf
Date: Wed Feb 28 2024 - 19:03:18 EST


On Wed, Feb 28, 2024 at 06:35:07PM -0500, Steven Rostedt wrote:
> On Sat, 25 Apr 2020 05:03:05 -0500
> Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
>
> > These variables aren't used outside of unwind_orc.c, make them static.
> >
> > Also annotate some of them with '__ro_after_init', as applicable.
>
> So it appears that crash uses "lookup_num_blocks" to be able to do
> back-traces with the ORC unwinder. But because it's now static, crash can no
> longer do that.

Hm, but why? Even a static variable has a known address.

--
Josh