Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs

From: Jakub Kicinski
Date: Wed Feb 28 2024 - 20:15:21 EST


On Wed, 28 Feb 2024 19:03:12 -0600 Gustavo A. R. Silva wrote:
> On 2/28/24 18:57, Jakub Kicinski wrote:
> > On Wed, 28 Feb 2024 18:49:25 -0600 Gustavo A. R. Silva wrote:
> >> struct net_device {
> >> struct_group_tagged(net_device_hdr, hdr,
> >> ...
> >> u32 priv_size;
> >> );
> >> u8 priv_data[] __counted_by(priv_size) __aligned(NETDEV_ALIGN);
> >> }
> >
> > No, no, that's not happening.
>
> Thanks, one less flex-struct to change. :)

I like the flex struct.
I don't like struct group around a 360LoC declaration just to avoid
having to fix up a handful of users.