Re: [PATCH] arm64: dts: qcom: sc7180: Disable DCC node by default

From: Doug Anderson
Date: Wed Feb 28 2024 - 20:51:33 EST


Hi,

On Wed, Feb 28, 2024 at 5:35 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> We don't use this device on Trogdor boards. If we did, it would be
> enabled in the sc7180-trogdor.dtsi file. Let's disable this here so that
> boards with t he sc7180 SoC can decide to enable or disable this device.

s/t he/the/


> Cc: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> Fixes: add74cad7c9d ("arm64: dts: qcom: sc7180: Add Data Capture and Compare(DCC) support node")
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 +
> 1 file changed, 1 insertion(+)

Seems fine to me. I guess the driver never landed, but if/when it
lands then it makes sense to just enable the device it for boards that
need it.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>