Re: [PATCH net] kunit: Fix again checksum tests on big endian CPUs

From: Palmer Dabbelt
Date: Wed Feb 28 2024 - 20:55:52 EST


On Wed, 28 Feb 2024 17:51:58 PST (-0800), kuba@xxxxxxxxxx wrote:
On Tue, 27 Feb 2024 10:06:41 +0100 Paolo Abeni wrote:
On Sat, 2024-02-24 at 07:44 +0000, Christophe Leroy wrote:
> Hi,
> > Le 23/02/2024 à 11:41, Christophe Leroy a écrit : > > Commit b38460bc463c ("kunit: Fix checksum tests on big endian CPUs")
> > fixed endianness issues with kunit checksum tests, but then
> > commit 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and
> > ip_fast_csum") introduced new issues on big endian CPUs. Those issues
> > are once again reflected by the warnings reported by sparse.
> > > > So, fix them with the same approach, perform proper conversion in
> > order to support both little and big endian CPUs. Once the conversions
> > are properly done and the right types used, the sparse warnings are
> > cleared as well.
> > > > Reported-by: Erhard Furtner <erhard_f@xxxxxxxxxxx>
> > Fixes: 6f4c45cbcb00 ("kunit: Add tests for csum_ipv6_magic and ip_fast_csum")
> > Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx> > > netdev checkpatch complains about "1 blamed authors not CCed: > palmer@xxxxxxxxxxxx; 1 maintainers not CCed: palmer@xxxxxxxxxxxx "
> > Palmer was copied but as Palmer Dabbelt <palmer@xxxxxxxxxxx>. Hope it is > not a show stopper.
No, it's not.

Acked-by: Paolo Abeni <pabeni@xxxxxxxxxx>

I *think* this, despite the subject prefix, should go via Andrew's tree
to avoid conflicts.

@Andrew does the above fits you?

I don't see this in linux-next, so unless told otherwise I'll merge it
and ship to Linus tomorrow.

Sorry, I thought I'd Ack'd this at some point -- I might have just gotten lost, though, as IIRC there were a few of these floating around.

I'm fine with anyone taking it, so

Acked-by: Palmer Dabbelt <palmer@xxxxxxxxxxxx>

Thanks!