RE: [PATCH net 1/3] net: lan743x: disable WOL upon resume to restore full data path operation

[Raju.Lakkaraju]

Hi Andrew,

Thank you for review comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, February 27, 2024 7:09 AM
> To: Raju Lakkaraju - I30499 <Raju.Lakkaraju@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Bryan Whitehead - C21958
> <Bryan.Whitehead@xxxxxxxxxxxxx>; richardcochran@xxxxxxxxx;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>
> Subject: Re: [PATCH net 1/3] net: lan743x: disable WOL upon resume to
> restore full data path operation
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Mon, Feb 26, 2024 at 01:39:32PM +0530, Raju Lakkaraju wrote:
> > In order for datapath to be restored to normal functionality after
> > resume we disable all wakeup events. Additionally we clear all W1C
> > status bits by writing 1's to them.
> 
> Just to make sure i'm understanding this correctly, you are just clearing that
> there was been a WoL wakeup. The WoL configuration is not cleared, so i
> could suspend the device again and wake it up with WoL. There is no need for
> me to use ethtool, the WoL configuration is preserved.

Yes. Your understanding is correct.
WoL configuration is not cleared. 
This clean-up helps us when resume from sleep due to system events.
There is no need to use ethtool's configure WOL again.

> 
>         Andrew

Thanks,
Raju