Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

From: Johan Hovold
Date: Thu Feb 29 2024 - 03:08:37 EST


On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
>
> Signed-off-by: Vamshi Gajjela <vamshigajjela@xxxxxxxxxx>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@xxxxxxxxxxxxxxx
> ---

This is v2, which should be indicated in the patch subject and with a
short changelog here (e.g. mentioning the split and rebase on 6.8-rc).

Johan