Re: [PATCH net-next v6 11/11] net: hisi_femac: add support for hisi_femac core on Hi3798MV200

From: Yang Xiwen
Date: Thu Feb 29 2024 - 03:15:15 EST


On 2/29/2024 4:10 PM, Krzysztof Kozlowski wrote:
> On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
>>
>> Register the sub MDIO bus if it is found. Also implement the internal
>> PHY reset procedure as needed.
>>
>
>
>>
>> @@ -947,6 +992,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
>> static const struct of_device_id hisi_femac_match[] = {
>> {.compatible = "hisilicon,hisi-femac",},
>> {.compatible = "hisilicon,hi3516cv300-femac",},
>> + {.compatible = "hisilicon,hi3798mv200-femac",},
>
> No, it does not make any sense. Why do you keep growing this table?

So do I only have to keep the generic compatible "hisilicon,hisi-femac"
or the two SoC compatibles?

>
> Best regards,
> Krzysztof
>

--
Best regards,
Yang Xiwen