Re: [PATCH net v3] ipv6:flush ipv6 route cache when rule is changed

[Lena Wang (王娜)]

On Wed, 2024-02-28 at 16:50 +0100, Jiri Pirko wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Wed, Feb 28, 2024 at 04:38:56PM CET, Lena.Wang@xxxxxxxxxxxx wrote:
> >From: Shiming Cheng <shiming.cheng@xxxxxxxxxxxx>
> >
> >When rule policy is changed, ipv6 socket cache is not refreshed.
> >The sock's skb still uses a outdated route cache and was sent to
> >a wrong interface.
> >
> >To avoid this error we should update fib node's version when
> >rule is changed. Then skb's route will be reroute checked as
> >route cache version is already different with fib node version.
> >The route cache is refreshed to match the latest rule.
> >
> >Signed-off-by: Shiming Cheng <shiming.cheng@xxxxxxxxxxxx>
> >Signed-off-by: Lena Wang <lena.wang@xxxxxxxxxxxx>
> 
> 1) You are still missing Fixes tags, I don't know what to say.
I am sorry for the confuse. My previous change log of fix tag is a
wrong description for "PATCH net v2".

Current patch doesn't fix previous commit. It is more like missing
flush since the first commit 101367c2f8c4 of creating fib6_rules.c. Is
it OK to add this fix or omit fix tag?

> 2) Re patch subject:
>    "ipv6:flush ipv6 route cache when rule is changed"
>    Could it be:
>    "ipv6: fib6_rules: flush route cache when rule is changed"
>    ? please.
Yes, I will update later in v4.

> 3) Could you please honor the 24h hours resubmission rule:
> 
https://www.kernel.org/doc/html/v6.6/process/maintainer-netdev.html#tl-dr
> 
OK. I will follow the rule later.

> pw-bot: cr