Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs

From: Jiri Pirko
Date: Thu Feb 29 2024 - 04:20:22 EST


Wed, Feb 28, 2024 at 05:47:45PM CET, kuba@xxxxxxxxxx wrote:
>On Wed, 28 Feb 2024 16:59:44 +0100 Larysa Zaremba wrote:
>> Allow to:
>> * receive LLDP packets on a VF
>> * transmit LLDP from a VF
>>
>> Only a single VF per port can transmit LLDP packets,
>> all trusted VFs can transmit LLDP packets.
>>
>> For both functionalities to work, private flag
>> fw-lldp-agent must be off.
>>
>> I am aware that implemented way of configuration (through sysfs) can be
>> potentially controversial and would like some feedback from outside.
>
>Why is the device not in switchdev mode? You can put your lldp-agent
>priv flag on repr netdevs.
>

But isn't it a matter of eswitch configuration? I mean, the user should
be free to configure filtering/forwarding of any packet, including LLDP
ones.