Re: [PATCH v3 1/2] dt-bindings: iio: adc: add ad7944 ADCs

From: Krzysztof Kozlowski
Date: Thu Feb 29 2024 - 04:41:14 EST


On 28/02/2024 19:10, David Lechner wrote:
> This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, and
> AD7986 ADCs.
>
> Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/adc/adi,ad7944.yaml | 213 +++++++++++++++++++++
> MAINTAINERS | 8 +
> 2 files changed, 221 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml
> new file mode 100644
> index 000000000000..2564ef4f58cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7944.yaml
> @@ -0,0 +1,213 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
>
> v2 changes:
> - Removed default 'multi' value from adi,spi-mode property. This simplifies
> things a bit by not having to check for two possible conditions (absence of
> property or explicit default value). Now, only absence of property is valid to
> indicate the default mode. Constraints that depend on this property are
> updated accordingly.
> - Fixed spelling of 'conventional'.
> - Expanded description to call out potential confusion of '3-wire' mode being
> unrelated to the standard spi-3wire property.
> - Added standard '#daisy-chained-devices' property for chain mode.
> - Relaxed requirement of cnv-gpios since it was determined that an active high
> CS could actually be used in chain mode.

? Please don't edit patches manually... Use git or git+b4. Or quilt?

Best regards,
Krzysztof