Re: [syzbot] [media?] [usb?] INFO: task hung in vb2_video_unregister_device

From: Edward Adam Davis
Date: Thu Feb 29 2024 - 06:24:09 EST


please test task hung in vb2_video_unregister_device

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master

diff --git a/drivers/media/usb/usbtv/usbtv-video.c b/drivers/media/usb/usbtv/usbtv-video.c
index 62a583040cd4..b55f432b44d4 100644
--- a/drivers/media/usb/usbtv/usbtv-video.c
+++ b/drivers/media/usb/usbtv/usbtv-video.c
@@ -963,7 +963,6 @@ int usbtv_video_init(struct usbtv *usbtv)

void usbtv_video_free(struct usbtv *usbtv)
{
- mutex_lock(&usbtv->vb2q_lock);
mutex_lock(&usbtv->v4l2_lock);

usbtv_stop(usbtv);
@@ -971,7 +970,6 @@ void usbtv_video_free(struct usbtv *usbtv)
v4l2_device_disconnect(&usbtv->v4l2_dev);

mutex_unlock(&usbtv->v4l2_lock);
- mutex_unlock(&usbtv->vb2q_lock);

v4l2_device_put(&usbtv->v4l2_dev);
}