Re: [PATCH V4 4/5] misc: mlx5ctl: Add command rpc ioctl

[Vegard Nossum]

On 07/02/2024 08:24, Saeed Mahameed wrote:
> @@ -328,6 +420,11 @@ static int mlx5ctl_probe(struct auxiliary_device *adev,
>   		goto abort;
>   	}
>   
> +	err = sysfs_create_link_nowarn(&mcdev->miscdev.this_device->kobj,
> +				       &mdev->device->kobj, "mdev");
> +	if (err)
> +		mlx5ctl_dbg(mcdev, "mlx5ctl: failed to create sysfs link err %d\n", err);
> +

Should this propagate the error to the caller?

What happens if/when mlx5ctl_remove()/sysfs_remove_link() gets called
later for this kobj?


Vegard