Re: [PATCH][next] pinctrl: ocelot: remove redundant assignment to variable ret

From: Linus Walleij
Date: Thu Feb 29 2024 - 08:38:50 EST


On Fri, Feb 23, 2024 at 5:28 PM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:

> The variable ret is being assigned a value that is never read, it
> is being re-assigned a value in every case statement in the following
> switch statement. The assignment is redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/pinctrl/pinctrl-ocelot.c:1404:3: warning: Value stored to 'ret'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Patch applied!

Yours,
Linus Walleij