Re: [PATCH 1/2] sched/core: switch struct rq->nr_iowait to a normal int

[Jens Axboe]

On 2/29/24 9:53 AM, Thomas Gleixner wrote:
> On Wed, Feb 28 2024 at 12:16, Jens Axboe wrote:
>> In 3 of the 4 spots where we modify rq->nr_iowait we already hold the
> 
> We modify something and hold locks? It's documented that changelogs
> should not impersonate code. It simply does not make any sense.

Agree it doesn't read that well... It's meant to say that we already
hold the rq lock in 3 of the 4 spots, hence using atomic_inc/dec is
pointless for those cases.

> Other than that:
> 
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>

Thanks for the review!

-- 
Jens Axboe