Re: [PATCH] ssb: Fix potential NULL pointer dereference in ssb_device_uevent

[Michael Büsch]

On Thu, 29 Feb 2024 12:37:56 +0300
Rand Deeb <rand.sec96@xxxxxxxxx> wrote:

>  static int ssb_device_uevent(struct device *dev, struct kobj_uevent_env *env)
>  {
> -	struct ssb_device *ssb_dev = dev_to_ssb_dev(dev);
> +	struct ssb_device *ssb_dev;
>  
>  	if (!dev)
>  		return -ENODEV;
>  
> +	ssb_dev = dev_to_ssb_dev(dev);
> +
>  	return add_uevent_var(env,
>  			     "MODALIAS=ssb:v%04Xid%04Xrev%02X",
>  			     ssb_dev->id.vendor, ssb_dev->id.coreid,

Good catch.
Acked-by: Michael Büsch <m@xxxxxxx>


-- 
Michael Büsch
https://bues.ch/

Attachment: pgpnNRVlxKc7E.pgp
Description: OpenPGP digital signature