Re: [PATCH v2 1/2] ASoC: dt-bindings: Added schema for "nuvoton,nau8325"

[WTLI]

Rob Herring 於 2/22/2024 10:16 PM 寫道:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> On Thu, Feb 22, 2024 at 04:38:24PM +0800, Seven Lee wrote:
> > Added a DT schema for describing nau8325 audio amplifiers.
> Please test your bindings before sending.

okay, thanks.

> > Signed-off-by: Seven Lee <wtli@xxxxxxxxxxx>
> > ---
> >   .../bindings/sound/nuvoton,nau8325.yaml       | 82 +++++++++++++++++++
> >   1 file changed, 82 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
> > new file mode 100644
> > index 000000000000..fc72baf0bb7a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8325.yaml
> > @@ -0,0 +1,82 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/nuvoton,nau8325.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: NAU8325 audio Amplifier
> > +
> > +maintainers:
> > +  - Seven Lee <WTLI@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: nuvoton,nau8325
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  nuvoton,vref-impedance:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> Use standard unit suffixes.

okay, I will use standard unit suffixes.

> > +    description:
> > +      VREF impedance selection.
> > +    enum:
> > +      - 0 # Open
> > +      - 1 # 25kOhm
> > +      - 2 # 125kOhm
> > +      - 3 # 2.5kOhm
> > +    default: 2
> > +
> > +  nuvoton,dac-vref:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> Use standard unit suffixes.

okay, I will use standard unit suffixes.

> > +    description:
> > +      DAC Reference Voltage Setting.
> > +    enum:
> > +      - VDDA
> in Volts?

yes, this is Volts.

> > +      - VDDA*1.5/1.8V
> Volts/Volts
>
> So 2 different units?

Both units are volts. I will modify the enum definition.

> > +      - VDDA*1.6/1.8V
> > +      - VDDA*1.7/1.8V
> > +    default: 2
> > +
> > +  nuvoton,alc-enable:
> > +    description:
> > +      Enable digital automatic level control (ALC) function.
> > +    type: boolean
> > +
> > +  nuvoton,clock-detection-disable:
> > +    description:
> > +      When clock detection is enabled, it will detect whether MCLK
> > +      and FS are within the range. MCLK range is from 2.048MHz to 24.576MHz.
> > +      FS range is from 8kHz to 96kHz.
> > +    type: boolean
> > +
> > +  nuvoton,clock-det-data:
> > +    description:
> > +      Request clock detection to require 2048 non-zero samples before enabling
> > +      the audio paths. If set then non-zero samples is required, otherwise it
> > +      doesn't matter.
> > +    type: boolean
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +        codec@21 {
> > +            compatible = "nuvoton,nau8325";
> > +            reg = <0x21>;
> > +            nuvoton,vref-impedance = <2>;
> > +            nuvoton,dac-vref = <2>;
> > +            nuvoton,alc-enable;
> > +            nuvoton,clock-det-data;
> > +        };
> > +    };
> > --
> > 2.25.1
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.