Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

[Mark Brown]

On Fri, Mar 01, 2024 at 10:33:15AM +0000, Ryan Roberts wrote:

>   - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...);
>     where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist,
>     then the open will fail I think? I'm pretty sure that's what's happening on
>     our CI. Suggest the test needs to setup this dir itself. Is thp_fs a mounted
>     fs or just a dir? If the latter can you just mktemp()?

Mounting on /mnt would also be a bit of an issue, that's something
people are relatively likely to have used for something so could be
disruptive.  If the test is going to do a new mount it's probably better
to do something like make a temporary directory then mount on top of that.

Attachment: signature.asc
Description: PGP signature