Re: [PATCH] tracing/net_sched: Fix tracepoints that save qdisc_dev() as a string

[Jamal Hadi Salim]

On Fri, Mar 1, 2024 at 2:59 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Fri, 1 Mar 2024 14:24:17 -0500
> Jamal Hadi Salim <jhs@xxxxxxxxxxxx> wrote:
>
> > > Fixes: a34dac0b90552 ("net_sched: add tracepoints for qdisc_reset() and qdisc_destroy()")
> > > Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> >
> > Should this be targeting the net tree?
>
> I was going to say that I need this for my work, but my work is aimed at
> the next merge window, but this should go into the kernel now and be marked
> for stable. So yes, it probably should go through the net tree.
>
> Do I need to resubmit it?
>

My view is it needs to be merged.
I note there are some big changes in net and net-next trees right now
that move the name - probably from 43a71cd66b9c0
Coco Li and Eric are on your Cc already.

> > Otherwise, LGTM. Just wondering - this worked before because "name"
> > was the first field?
>
> Looks like it. See commit 43a71cd66b9c0 ("net-device: reorganize net_device
> fast path variables")
>
> I wonder if there's anything else that uses a pointer to struct net_device
> thinking it can just be switched to find the name?
>

>From a quick scan i cant find anything obvious.

cheers,
jamal

> >
> > Reviewed-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx>
>
> Thanks,
>
> -- Steve