Re: [PATCH v2 3/7] tracing/probes: cleanup: Set trace_probe::nr_args at trace_probe_init

[Google]

On Thu, 29 Feb 2024 22:37:53 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 26 Feb 2024 12:58:23 +0900
> "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> wrote:
> 
> > From: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > 
> > Instead of incrementing the trace_probe::nr_args, init it at trace_probe_init().
> > This is a cleanup, so the behavior is not changed.
> 
> The change is fine, but the change log does not say why this was done.

This change is to get the number of trace_probe arguments while parsing
the argument strings.

Thank you,

> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> 
> -- Steve
> 
> 
> > 
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> > ---


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>