Re: [PATCH v4 2/2] sched/fair: Use helper function to access rd->overutilized

[Shrikanth Hegde]

On 3/4/24 12:24 AM, Qais Yousef wrote:
> On 03/01/24 20:47, Shrikanth Hegde wrote:
>> Overutilized field is accessed directly in multiple places.
>> So it could use a helper function. That way one might be more
>> informed that it needs to be used only in case of EAS.
>>
>> No change in functionality intended.
>>
>> Signed-off-by: Shrikanth Hegde <sshegde@xxxxxxxxxxxxx>
> 
> Can we do the same for rd->overload too? A set_rd_overload_status() would be
> a nice addition too. Anyway.


We have some more experiments going around overload. 
For example, currently it is writing sg_status & SG_OVERLOAD without checking if it has 
changed first. On large systems that are not overloaded, that may help by reducing the 
bus traffic. 

I will pick up this after we have some more data on the above. 

> 
> Reviewed-by: Qais Yousef <qyousef@xxxxxxxxxxx>
> 

Thank you.

> 
> Thanks!