Re: [PATCH net-next v2] tcp: Add skb addr and sock addr to arguments of tracepoint tcp_probe.

[yuanli fu]

Eric Dumazet <edumazet@xxxxxxxxxx> 于2024年3月4日周一 16:13写道：
>
> On Mon, Mar 4, 2024 at 4:46 AM fuyuanli <fuyuanli@xxxxxxxxxxxxxx> wrote:
> >
> > It is useful to expose skb addr and sock addr to user in tracepoint
> > tcp_probe, so that we can get more information while monitoring
> > receiving of tcp data, by ebpf or other ways.
> >
> > For example, we need to identify a packet by seq and end_seq when
> > calculate transmit latency between lay 2 and lay 4 by ebpf, but which is
>
> Please use "layer 2 and layer 4".
>
> > not available in tcp_probe, so we can only use kprobe hooking
> > tcp_rcv_esatblised to get them. But we can use tcp_probe directly if skb
> > addr and sock addr are available, which is more efficient.
>
> Okay, but please fix the typo. Correct function name is tcp_rcv_established
>
> >
> > Signed-off-by: fuyuanli <fuyuanli@xxxxxxxxxxxxxx>
> > Link: https://lore.kernel.org/netdev/20240229052813.GA23899@didi-ThinkCentre-M920t-N000/
> >
>
OK, I will submit a v3 patch, thanks for your review :)
fuyuanli