Re: [PATCH net-next v7 4/9] dt-bindings: net: convert hisi-femac.txt to YAML

[Yang Xiwen]

On 3/1/2024 2:49 PM, Krzysztof Kozlowski wrote:
> On 01/03/2024 04:35, Yang Xiwen via B4 Relay wrote:
> > From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> >
> > Convert the old text binding to new YAML.
> >
> > While at it, make some changes to the binding:
> > - The version numbers are not documented publicly. The version also does
> > not change programming interface. Remove it until it's really needed.
> > - A few clocks are missing in old binding file. Add them to match the real
> > hardware.
> >
> > Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
> > ---
> >   .../bindings/net/hisilicon,hisi-femac.yaml         | 89 ++++++++++++++++++++++
> >   .../devicetree/bindings/net/hisilicon-femac.txt    | 41 ----------
> >   2 files changed, 89 insertions(+), 41 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> > new file mode 100644
> > index 000000000000..ba207f2c9ae4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
> > @@ -0,0 +1,89 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/hisilicon,hisi-femac.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Hisilicon Fast Ethernet MAC controller
> > +
> > +maintainers:
> > +  - Yang Xiwen <forbidden405@xxxxxxxxxxx>
> > +
> > +allOf:
> > +  - $ref: ethernet-controller.yaml
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - hisilicon,hi3516cv300-femac
> > +      - const: hisilicon,hisi-femac
>
> This is a friendly reminder during the review process.
>
> It seems my or other reviewer's previous comments were not fully
> addressed. Maybe the feedback got lost between the quotes, maybe you
> just forgot to apply it. Please go back to the previous discussion and
> either implement all requested changes or keep discussing them.


Could you please tell me which one did i miss? I have read all replies 
to v1-v7 once again and fails to find one.


Do you mean the discussion about "phy-mode" and "phy-connection-type"? 
I've decided to drop that commit and stick to "phy-mode", in this patch set.


> Thank you.
>
>
>
> Best regards,
> Krzysztof

--
Regards,
Yang Xiwen