Re: [PATCH] loongarch: rust: Switch to use built-in rustc target
From: Huacai Chen
Date: Tue Mar 05 2024 - 04:59:01 EST
Hi, Miguel,
On Tue, Mar 5, 2024 at 12:07 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Mon, Mar 4, 2024 at 3:14 PM WANG Rui <wangrui@xxxxxxxxxxx> wrote:
> >
> > This commit switches to using the built-in rustc
> > loongarch64-unknown-none-softfloat target for LoongArch.
> >
> > The Rust samples have been tested with this commit.
> >
> > Signed-off-by: WANG Rui <wangrui@xxxxxxxxxxx>
> > ---
> > base-commit: ("rust: Refactor the build target to allow the use of builtin targets")
>
> I couldn't apply it on top of commit f82811e22b48 in arm64's tree
> (which is the base? -- the offset differs significantly in the arch
> Makefile), but I nevertheless applied it manually on top of that one,
> build-tested it for loongarch64 and boot-tested it for x86_64:
>
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Tested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
The base of the loongarch tree doesn't contain the arm64 modifications
now, so this patch is better to be applied on the rust tree with my
Acked-by. But if you have some trouble doing that, I can also manually
merge the arm64 parts to the loongarch tree, and then apply this
patch. Thanks.
Huacai
>
> Thanks!
>
> Cheers,
> Miguel