Re: [PATCH v12 3/9] firmware: qcom: scm: Modify only the download bits in TCSR register

[Mukesh Ojha]

On 3/3/2024 12:43 AM, Bjorn Andersson wrote:
> On Tue, Feb 27, 2024 at 09:23:02PM +0530, Mukesh Ojha wrote:
> > Crashdump collection is done based on DLOAD bits of TCSR register.
> > To retain other bits, scm driver need to read the register and
> > modify only the DLOAD bits, as other bits in TCSR may have their
> > own significance.
> >
> > Co-developed-by: Poovendhan Selvaraj <quic_poovendh@xxxxxxxxxxx>
> > Signed-off-by: Poovendhan Selvaraj <quic_poovendh@xxxxxxxxxxx>
> > Signed-off-by: Mukesh Ojha <quic_mojha@xxxxxxxxxxx>
> > Tested-by: Kathiravan Thirumoorthy <quic_kathirav@xxxxxxxxxxx> # IPQ9574 and IPQ5332
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Reviewed-by: Elliot Berman <quic_eberman@xxxxxxxxxxx>
> > ---
> >   drivers/firmware/qcom/qcom_scm.c | 14 ++++++++++++--
> >   1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c
> > index 8f766fce5f7c..bd6bfdf2d828 100644
> > --- a/drivers/firmware/qcom/qcom_scm.c
> > +++ b/drivers/firmware/qcom/qcom_scm.c
> > @@ -4,6 +4,8 @@
> >    */
> >   
> >   #include <linux/arm-smccc.h>
> > +#include <linux/bitfield.h>
> > +#include <linux/bits.h>
> >   #include <linux/clk.h>
> >   #include <linux/completion.h>
> >   #include <linux/cpumask.h>
> > @@ -114,6 +116,12 @@ static const u8 qcom_scm_cpu_warm_bits[QCOM_SCM_BOOT_MAX_CPUS] = {
> >   #define QCOM_SMC_WAITQ_FLAG_WAKE_ONE	BIT(0)
> >   #define QCOM_SMC_WAITQ_FLAG_WAKE_ALL	BIT(1)
> >   
> > +#define QCOM_DLOAD_MASK		GENMASK(5, 4)
> > +enum qcom_dload_mode {
> > +	QCOM_DLOAD_NODUMP	= 0,
> > +	QCOM_DLOAD_FULLDUMP	= 1,
>
> These values are not enumerations, they represent fixed/defined values
> in the interface. As such it's appropriate to use #define.

Thanks for giving reasoning on why it should be #define and not enum.

-Mukesh