Re: [PATCH v3 10/10] mm/treewide: Align up pXd_leaf() retval across archs
From: Jason Gunthorpe
Date: Tue Mar 05 2024 - 09:33:26 EST
On Tue, Mar 05, 2024 at 12:37:50PM +0800, peterx@xxxxxxxxxx wrote:
> From: Peter Xu <peterx@xxxxxxxxxx>
>
> Even if pXd_leaf() API is defined globally, it's not clear on the retval,
> and there are three types used (bool, int, unsigned log).
>
> Always return a boolean for pXd_leaf() APIs.
>
> Suggested-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
> ---
> arch/riscv/include/asm/pgtable-64.h | 2 +-
> arch/riscv/include/asm/pgtable.h | 2 +-
> arch/s390/include/asm/pgtable.h | 4 ++--
> arch/sparc/include/asm/pgtable_64.h | 4 ++--
> arch/x86/include/asm/pgtable.h | 8 ++++----
> include/linux/pgtable.h | 8 ++++----
> 6 files changed, 14 insertions(+), 14 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
Jason