[PATCH v2 2/2] clk: test: use __clk_mux_determine_rate() and remove FIXME
From: Yang Xiwen via B4 Relay
Date: Tue Mar 05 2024 - 11:25:46 EST
From: Yang Xiwen <forbidden405@xxxxxxxxxxx>
Recent clk core fix resolved the bug in the FIXME comment. Now replace
the .determine_rate field back to __clk_mux_determine_rate() and remove
the FIXME comment.
Fixes: aebddfe2dfaf ("clk: test: Add a determine_rate hook")
Signed-off-by: Yang Xiwen <forbidden405@xxxxxxxxxxx>
---
drivers/clk/clk_test.c | 18 +-----------------
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/clk/clk_test.c b/drivers/clk/clk_test.c
index 39e2b5ff4f51..0c91dc14d942 100644
--- a/drivers/clk/clk_test.c
+++ b/drivers/clk/clk_test.c
@@ -106,23 +106,7 @@ static const struct clk_ops clk_dummy_minimize_rate_ops = {
};
static const struct clk_ops clk_dummy_single_parent_ops = {
- /*
- * FIXME: Even though we should probably be able to use
- * __clk_mux_determine_rate() here, if we use it and call
- * clk_round_rate() or clk_set_rate() with a rate lower than
- * what all the parents can provide, it will return -EINVAL.
- *
- * This is due to the fact that it has the undocumented
- * behaviour to always pick up the closest rate higher than the
- * requested rate. If we get something lower, it thus considers
- * that it's not acceptable and will return an error.
- *
- * It's somewhat inconsistent and creates a weird threshold
- * between rates above the parent rate which would be rounded to
- * what the parent can provide, but rates below will simply
- * return an error.
- */
- .determine_rate = __clk_mux_determine_rate_closest,
+ .determine_rate = __clk_mux_determine_rate,
.set_parent = clk_dummy_single_set_parent,
.get_parent = clk_dummy_single_get_parent,
};
--
2.43.0