Re: [PATCH 4/4] scsi: ufs: Re-use compose_devman_upiu

[Bart Van Assche]

On 3/4/24 01:23, Avri Altman wrote:
> +static void __compose_devman_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
> +				  u8 *upiu_flags, int ehs_length)
> +{
> +	if (hba->ufs_version <= ufshci_version(1, 1))
> +		lrbp->command_type = UTP_CMD_TYPE_DEV_MANAGE;
> +	else
> +		lrbp->command_type = UTP_CMD_TYPE_UFS_STORAGE;
> +
> +	ufshcd_prepare_req_desc_hdr(lrbp, upiu_flags, DMA_NONE, ehs_length);
> +}

Please move the above if-statement into ufshcd_prepare_req_desc_hdr() 
instead of introducing yet another helper function.

Thanks,

Bart.