Re: [PATCH] firmware: qcom_scm: disable clocks if qcom_scm_bw_enable() fails

[Konrad Dybcio]

On 3/4/24 14:14, Gabor Juhos wrote:
> There are several functions which are calling qcom_scm_bw_enable()
> then returns immediately if the call fails and leaves the clocks
> enabled.
>
> Change the code of these functions to disable clocks when the
> qcom_scm_bw_enable() call fails. This also fixes a possible dma
> buffer leak in the qcom_scm_pas_init_image() function.
>
> Compile tested only due to lack of hardware with interconnect
> support.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 65b7ebda5028 ("firmware: qcom_scm: Add bw voting support to the SCM interface")
> Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx>
> ---

Taking a closer look, is there any argument against simply
putting the clk/bw en/dis calls in qcom_scm_call()?

Konrad