Re: [PATCH net v2 1/1] net: dsa: microchip: make sure drive strength configuration is not lost by soft reset

[Arun.Ramadoss]

Hi Jakub,

On Tue, 2024-03-05 at 19:14 -0800, Jakub Kicinski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On Tue,  5 Mar 2024 07:48:02 +0100 Oleksij Rempel wrote:
> > This driver has two separate reset sequence in different places:
> > - gpio/HW reset on start of ksz_switch_register()
> > - SW reset on start of ksz_setup()
> > 
> > The second one will overwrite drive strength configuration made in
> > the
> > ksz_switch_register().
> > 
> > To fix it, move ksz_parse_drive_strength() from
> > ksz_switch_register() to
> > ksz_setup().
> > 
> > Fixes: d67d7247f641 ("net: dsa: microchip: Add drive strength
> > configuration")
> > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> 
> Hm, this is much larger than I anticipated, and also doesn't apply,
> so there will be conflict with -next. Andrew, should we go back to
> the v1?

Suggestion: Instead of moving ksz_parse_drive_strength() from end of
file to above, can we move ksz_setup() & ksz_teardown() down. So that
the changes will be minimal. Will that work?