Re: [PATCH 3/5] spi: spi-qpic: Add qpic spi nand driver support

[Md Sadre Alam]

Konrad,

On 2/20/2024 5:44 PM, Md Sadre Alam wrote:
> > > +    ecc_cfg->cfg0 = (cwperpage - 1) << CW_PER_PAGE
> > > +                | ecc_cfg->cw_data << UD_SIZE_BYTES
> > > +                | 1 << DISABLE_STATUS_AFTER_WRITE
> > > +                | 3 << NUM_ADDR_CYCLES
> > > +                | ecc_cfg->ecc_bytes_hw << ECC_PARITY_SIZE_BYTES_RS
> > > +                | 0 << STATUS_BFR_READ
> > > +                | 1 << SET_RD_MODE_AFTER_STATUS
> > > +                | ecc_cfg->spare_bytes << SPARE_SIZE_BYTES;
> >
> > Let me introduce you to FIELD_PREP/GET and GENMASK().. Many assignments
> > in this file could use these.
>
>   Ok

While doing the change i realized that it will impact raw nand driver as well.
Shall I post this change as separate patch. Is this ok? Please let me know.

Regards,
Alam.

> > Konrad
>
> Thanks for reviewing, will fix all the comments in next patch.
>
> Regards,
> Alam.