Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and Power buttons

[Krzysztof Kozlowski]

On 06/03/2024 04:02, hui liu wrote:
> 
> 
> On 3/6/2024 5:20 AM, Konrad Dybcio wrote:
>>
>>
>> On 3/4/24 08:09, Hui Liu via B4 Relay wrote:
>>> From: Hui Liu <quic_huliu@xxxxxxxxxxx>
>>>
>>> The Volume Down & Power buttons are controlled by the PMIC via
>>> the PON hardware, and the Volume Up is connected to a PMIC gpio.
>>>
>>> Enable the necessary hardware and setup the GPIO state for the
>>> Volume Up gpio key.
>>>
>>> Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
>>> ---
>>
>> [...]
>>
>>
>>> +&pmk8350_pon {
>>> +    status = "okay";
>>> +};
>>
>> This device is already enabled
> Hi Konrad,
> 
> The status is not set in pmk8350.dtsi, so I thought we should set it for 
> "okay" manually. Do you think so?

No.

Best regards,
Krzysztof