RE: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant NULL-check

[Vadim Pasternak]

> -----Original Message-----
> From: Daniil Dulov <d.dulov@xxxxxxxxxx>
> Sent: Wednesday, 6 March 2024 17:38
> To: Vadim Pasternak <vadimp@xxxxxxxxxx>
> Cc: Daniil Dulov <d.dulov@xxxxxxxxxx>; Mark Gross
> <mgross@xxxxxxxxxxxxxxx>; Andy Shevchenko <andy@xxxxxxxxxxxxx>; Darren
> Hart <dvhart@xxxxxxxxxxxxx>; Hans de Goede <hdegoede@xxxxxxxxxx>;
> platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; lvc-
> project@xxxxxxxxxxxxxxxx
> Subject: [PATCH] platform/mellanox: mlxreg-hotplug: Remove redundant
> NULL-check
> 
> Pointer item is checked fo NULL at mlxreg_hotplug_work_helper() and then it
> is dereferenced to produce dev_err().
> This pointer is also dereferenced before calling this function and should never
> be NULL except some piece of hardware is broken as it is said in the comment
> before the check. So, this check can be safely removed.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: c6acad68eb2d ("platform/mellanox: mlxreg-hotplug: Modify to use a
> regmap interface")
> Signed-off-by: Daniil Dulov <d.dulov@xxxxxxxxxx>

Reviewed-by: Vadim Pasternak <vadimp@xxxxxxxxxx>

> ---
>  drivers/platform/mellanox/mlxreg-hotplug.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-hotplug.c
> b/drivers/platform/mellanox/mlxreg-hotplug.c
> index 5c022b258f91..0ce9fff1f7d4 100644
> --- a/drivers/platform/mellanox/mlxreg-hotplug.c
> +++ b/drivers/platform/mellanox/mlxreg-hotplug.c
> @@ -348,20 +348,6 @@ mlxreg_hotplug_work_helper(struct
> mlxreg_hotplug_priv_data *priv,
>  	u32 regval, bit;
>  	int ret;
> 
> -	/*
> -	 * Validate if item related to received signal type is valid.
> -	 * It should never happen, excepted the situation when some
> -	 * piece of hardware is broken. In such situation just produce
> -	 * error message and return. Caller must continue to handle the
> -	 * signals from other devices if any.
> -	 */
> -	if (unlikely(!item)) {
> -		dev_err(priv->dev, "False signal: at offset:mask
> 0x%02x:0x%02x.\n",
> -			item->reg, item->mask);
> -
> -		return;
> -	}
> -
>  	/* Mask event. */
>  	ret = regmap_write(priv->regmap, item->reg +
> MLXREG_HOTPLUG_MASK_OFF,
>  			   0);
> --
> 2.25.1