Re: [PATCH v4 2/4] ASoC: dt-bindings: fsl,imx-asrc: update max interrupt numbers
From: Rob Herring
Date: Wed Mar 06 2024 - 15:25:51 EST
On Tue, Mar 05, 2024 at 12:33:03PM -0500, Frank Li wrote:
> fsl,imx8qxp-spdif and fsl,imx8qm-spdif have 2 interrupts. Other platforms
> have 1 interrupt.
>
> Increase max interrupt number to 2 and add restriction for platforms except
> i.MX8QXP and i.MX8QM.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/fsl,spdif.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> index 56f8c0c8afdea..7f6590708e1ec 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,spdif.yaml
> @@ -31,7 +31,8 @@ properties:
> maxItems: 1
>
> interrupts:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> dmas:
> items:
> @@ -101,6 +102,21 @@ required:
> additionalProperties: false
>
> allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - fsl,imx8qm-spdif
> + - fsl,imx8qxp-spdif
> + then:
> + properties:
> + interrupts:
> + minItems: 2
Nowhere is it explained what the 2 interrupts are or what the order of
them is. Is the first interrupt the same as before, and there is a new
interrupt for something else? Or it's the same interrupts, but they've
just split up into 2?
Rob