Re: [PATCH] docs: w1: Remove w1_gpio_platform_data

[Randy Dunlap]

On 3/6/24 11:46, Ayush Singh wrote:
> `linux/w1-gpio.h` was removed in a previous patch and should no longer be
> needed for using w1 gpio.
> 
> - Removal Patch: https://lore.kernel.org/all/cover.1701727212.git.u.kleine-koenig@xxxxxxxxxxxxxx/
> 
> Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx>

Possibly add:
Fixes: 9c0a5b3f9e55 ("w1: gpio: Don't use platform data for driver data")

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Thanks.

> ---
>  Documentation/w1/masters/w1-gpio.rst | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/Documentation/w1/masters/w1-gpio.rst b/Documentation/w1/masters/w1-gpio.rst
> index 15236605503b..5d7eebc291bb 100644
> --- a/Documentation/w1/masters/w1-gpio.rst
> +++ b/Documentation/w1/masters/w1-gpio.rst
> @@ -20,7 +20,6 @@ Example (mach-at91)
>  ::
>  
>    #include <linux/gpio/machine.h>
> -  #include <linux/w1-gpio.h>
>  
>    static struct gpiod_lookup_table foo_w1_gpiod_table = {
>  	.dev_id = "w1-gpio",
> @@ -30,14 +29,9 @@ Example (mach-at91)
>  	},
>    };
>  
> -  static struct w1_gpio_platform_data foo_w1_gpio_pdata = {
> -	.ext_pullup_enable_pin	= -EINVAL,
> -  };
> -
>    static struct platform_device foo_w1_device = {
>  	.name			= "w1-gpio",
>  	.id			= -1,
> -	.dev.platform_data	= &foo_w1_gpio_pdata,
>    };
>  
>    ...

-- 
#Randy