Re: [syzbot] [net?] possible deadlock in team_port_change_check (2)
From: Edward Adam Davis
Date: Thu Mar 07 2024 - 04:31:33 EST
please test dl in team_port_change_check
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index f575f225d417..ecce44b16e4f 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -1212,7 +1212,9 @@ static int team_port_add(struct team *team, struct net_device *port_dev,
goto err_port_enter;
}
+ mutex_unlock(&team->lock);
err = dev_open(port_dev, extack);
+ mutex_lock(&team->lock);
if (err) {
netdev_dbg(dev, "Device %s opening failed\n",
portname);