RE: [PATCH net 6/8] net: hns3: fix reset timeout under full functions and queues

[Sunil Kovvuri Goutham]

> -----Original Message-----
> From: Jijie Shao <shaojijie@xxxxxxxxxx>
> Sent: Thursday, March 7, 2024 6:31 AM
> To: yisen.zhuang@xxxxxxxxxx; salil.mehta@xxxxxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx
> Cc: shenjian15@xxxxxxxxxx; wangjie125@xxxxxxxxxx;
> liuyonglong@xxxxxxxxxx; shaojijie@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] [PATCH net 6/8] net: hns3: fix reset timeout under full
> functions and queues
> 
> From: Peiyang Wang <wangpeiyang1@xxxxxxxxxx>
> 
> The cmdq reset command times out when all VFs are enabled and the
> queue is full. The hardware processing time exceeds the timeout set by the
> driver.
> In order to avoid the above extreme situations, the driver extends the reset
> timeout to 1 second.
> 

Reviewed-by: Sunil Goutham <sgoutham@xxxxxxxxxxx>

But one observation, loop of udelay(1) for 1sec seems a lot, probably better to use usleep_range().