Re: [PATCH] cdrom: gdrom: Convert to platform remove callback returning void
From: Jens Axboe
Date: Thu Mar 07 2024 - 14:35:56 EST
On Thu, 07 Mar 2024 19:08:37 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> [...]
Applied, thanks!
[1/1] cdrom: gdrom: Convert to platform remove callback returning void
commit: 0dc31b98d7200a0046de5c760feb0aaff6c4b53c
Best regards,
--
Jens Axboe