Re: [PATCH v5 2/2] pwm: sophgo: add pwm support for Sophgo CV1800 SoC

[Jingbao Qiu]

On Sat, Mar 16, 2024 at 3:22 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
> Hello,
>
> On Sat, Mar 16, 2024 at 09:41:46AM +0800, Jisheng Zhang wrote:
> > On Thu, Mar 14, 2024 at 06:01:31PM +0800, Jingbao Qiu wrote:
> > > +static void cv1800_pwm_set_oe(struct pwm_chip *chip, struct pwm_device *pwm,
> > > +                         u32 mode)
> >
> > Did you get any information about the capture support pwm controller?
>
> Instead of adding capture support to this pwm driver, I'd rather see
> support added to the counter subsystem. That's more versatile.
>
> See https://lore.kernel.org/linux-pwm/Y3aze3B6%2Fe5uWS%2FH@fedora for
> some more context.
>

Thank you for your suggestion. I will add support for the counter subsystem
after communicating with the hardware designer about the input function of PWM.
Do you have any suggestions for this patch?

Best regards
Jingbao Qiu